Messages in this thread | | | Date | Tue, 19 Oct 2010 19:39:55 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [patch]x86: spread tlb flush vector between nodes |
| |
On 10/19/2010 06:13 PM, Shaohua Li wrote: > On Tue, 2010-10-19 at 21:34 +0800, Andi Kleen wrote: >>> >>> +static int tlb_vector_offset[NR_CPUS] __read_mostly; >> >> Never use NR_CPUS. Always use per cpu data. >> >> Otherwise you waste a lot of space on a CONFIG_MAX_SMP >> kernel running on a smaller box. > ha, I want it to be __read_mostly to avoid cache pollution, apparently > we have no per cpu API to do this. Maybe I need add one. >
Quite possible, however, definitely percpu over a static array.
-hpa
-- H. Peter Anvin, Intel Open Source Technology Center I work for Intel. I don't speak on their behalf.
| |