| | Date | Wed, 20 Oct 2010 13:38:28 +1100 | | From | Nick Piggin <> | | Subject | Re: [patch 26/35] fs: icache alloc anonymous inode allocation |
| |
On Tue, Oct 19, 2010 at 05:50:00PM +0200, Miklos Szeredi wrote: > On Tue, 19 Oct 2010, npiggin@kernel.d wrote: > > Index: linux-2.6/fs/anon_inodes.c > > =================================================================== > > --- linux-2.6.orig/fs/anon_inodes.c 2010-10-19 14:18:58.000000000 +1100 > > +++ linux-2.6/fs/anon_inodes.c 2010-10-19 14:19:19.000000000 +1100 > > @@ -191,7 +191,7 @@ > > */ > > static struct inode *anon_inode_mkinode(void) > > { > > - struct inode *inode = new_inode(anon_inode_mnt->mnt_sb); > > + struct inode *inode = new_anon_inode(anon_inode_mnt->mnt_sb); > > > > if (!inode) > > return ERR_PTR(-ENOMEM); > > This too needs an inode->i_ino initialization (the default ULONG_MAX > will cause EOVERFLOW on 32bit fstat, AFAIK), though it could just be a > constant, say 2.
OK. I'll add a #define for it. Thanks
|