lkml.org 
[lkml]   [2010]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 33/35] fs: icache introduce inode_get/inode_get_ilock
    On Tue, Oct 19, 2010 at 12:17:31PM +0200, Boaz Harrosh wrote:
    > On 10/19/2010 05:42 AM, npiggin@kernel.dk wrote:
    > > Index: linux-2.6/fs/exofs/namei.c
    > > ===================================================================
    > > --- linux-2.6.orig/fs/exofs/namei.c 2010-10-19 14:18:58.000000000 +1100
    > > +++ linux-2.6/fs/exofs/namei.c 2010-10-19 14:19:00.000000000 +1100
    > > @@ -153,9 +153,7 @@
    > >
    > > inode->i_ctime = CURRENT_TIME;
    > > inode_inc_link_count(inode);
    > > - spin_lock(&inode->i_lock);
    > > - inode->i_count++;
    > > - spin_unlock(&inode->i_lock);
    > > + inode_get(inode);
    > >
    > > return exofs_add_nondir(dentry, inode);
    > > }
    >
    > Why won't you define an intermediate inode_get() in patch 08/35 and
    > change both puts and gets of all file_systems in one patch? Instead
    > of two tree sweeping patches. (At least for all the trivial places
    > like here)

    I hadn't wanted to make non locking related changes before inode
    lock was removed. But yes it may make sense just to do the name
    change. I'll see how it looks.

    Thanks,
    Nick



    \
     
     \ /
      Last update: 2010-10-20 04:19    [W:0.019 / U:0.492 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site