lkml.org 
[lkml]   [2010]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/3] IMA: move read/write counters into struct inode
    On Tue, Oct 19, 2010 at 06:28:05PM +0100, Al Viro wrote:
    > I'd rather not say what I think about IMA sanity (and usefulness); as for what
    > it tries to do... They want to whine if you open a file that is already opened
    > for write and they want to whine if you open a file for write when it's already
    > opened for read. Unless they decide to leave the file alone, that is.

    Hm. Sounds like the same question that the file leases code needs
    answered. The important difference is that the leases code can just
    refuse to set a lease on inodes with multiple dentries.

    While my mind's on it ... Al, is this code even close to correct?

    if ((arg == F_RDLCK) && (atomic_read(&inode->i_writecount) > 0))
    goto out;
    if ((arg == F_WRLCK)
    && ((atomic_read(&dentry->d_count) > 1)
    || (atomic_read(&inode->i_count) > 1)))
    goto out;

    --
    Matthew Wilcox Intel Open Source Technology Centre
    "Bill, look, we understand that you're interested in selling us this
    operating system, but compare it to ours. We can't possibly take such
    a retrograde step."


    \
     
     \ /
      Last update: 2010-10-19 21:13    [W:0.019 / U:0.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site