lkml.org 
[lkml]   [2010]   [Oct]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/3] usb: trivial Kconfig cleanups
From
On Tue, Oct 19, 2010 at 8:50 PM, Greg KH <greg@kroah.com> wrote:
> On Tue, Oct 19, 2010 at 08:15:19PM +0300, Felipe Contreras wrote:
>> On Tue, Oct 19, 2010 at 6:51 PM, Greg KH <greg@kroah.com> wrote:
>> > On Tue, Oct 19, 2010 at 01:03:27PM +0300, Felipe Contreras wrote:
>> >> Note: USB_GADGET_MUSB_HDRC is already defined in usb/gadget.
>> >>
>> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
>> >
>> > Please describe _what_ trivial cleanups you did, and why you did them.
>> > Care to resend?
>>
>> How about:
>> Shuffle the code a bit so the description is at the top, remove
>> duplicated configs (USB_GADGET_MUSB_HDRC),  'default n' is redundant,
>> and USB_GADGET_SELECTED should go after USB_GADGET (on the appropriate
>> config).
>
> Sounds good, but you need to resend it with this information in it, not
> much I can do with it in an independant email.

I know that, I just wanted to see if it was ok before resending so I
don't resend another time.

--
Felipe Contreras
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-10-19 20:17    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site