lkml.org 
[lkml]   [2010]   [Oct]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateTue, 19 Oct 2010 10:35:37 +0800
FromWu Fengguang <>
SubjectRe: Deadlock possibly caused by too_many_isolated.
> @@ -2054,10 +2069,11 @@ rebalance:
> goto got_pg;
>
> /*
> - * If we failed to make any progress reclaiming, then we are
> - * running out of options and have to consider going OOM
> + * If we failed to make any progress reclaiming and there aren't
> + * many parallel reclaiming, then we are unning out of options and
> + * have to consider going OOM
> */
> - if (!did_some_progress) {
> + if (!did_some_progress && !too_many_isolated_zone(preferred_zone)) {
> if ((gfp_mask & __GFP_FS) && !(gfp_mask & __GFP_NORETRY)) {
> if (oom_killer_disabled)
> goto nopage;

This is simply wrong.

It disabled this block for 99% system because there won't be enough
tasks to make (!too_many_isolated_zone == true). As a result the LRU
will be scanned like mad and no task get OOMed when it should be.

Thanks,
Fengguang


\
 
 \ /
  Last update: 2010-10-19 04:37    [from the cache]
©2003-2010