Messages in this thread | | | Date | Mon, 18 Oct 2010 19:18:40 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 1/2] Add vzalloc shortcut |
| |
On Tue, 19 Oct 2010 09:55:17 +0800 Dave Young <hidave.darkstar@gmail.com> wrote:
> On Tue, Oct 19, 2010 at 9:27 AM, Dave Young <hidave.darkstar@gmail.com> wrote: > > On Tue, Oct 19, 2010 at 7:46 AM, Andrew Morton > >> > >> Also, a slightly better implementation would be > >> > >> static inline void * vmalloc_node_flags(unsigned long size, gfp_t flags) > >> { > >> return vmalloc_node(size, 1, flags, PAGE_KERNEL, -1, > >> builtin_return_address(0)); > >> } > > Is this better? might vmalloc_node_flags would be used by other than vmalloc? > > static inline void * vmalloc_node_flags(unsigned long size, int node, > gfp_t flags)
I have no strong opinions, really. If we add more and more arguments to vmalloc_node_flags() it ends up looking like vmalloc_node(), so we may as well just call vmalloc_node(). Do whatever feels good ;)
| |