Messages in this thread | | | Subject | Re: [PATCH] checkpatch: allow single space before labels | From | Joe Perches <> | Date | Sun, 17 Oct 2010 01:21:18 -0700 |
| |
On Sun, 2010-10-17 at 04:05 -0400, Mike Frysinger wrote: > Signed-off-by: Mike Frysinger <vapier@gentoo.org> > diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl [] > # check for spaces at the beginning of a line. > - if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/) { > + if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/ && $rawline !~ /:$/) {
Perhaps that's not an ideal test. Maybe "&& $rawline !~ /^\+ \w+:/" is better.
The current test misidentify labels with comments: drivers/net/tulip/interrupt.c: oom: /* Executed with RX ints disabled */
| |