lkml.org 
[lkml]   [2010]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] checkpatch: allow single space before labels
From
Date
On Sun, 2010-10-17 at 04:05 -0400, Mike Frysinger wrote:
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
[]
> # check for spaces at the beginning of a line.
> - if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/) {
> + if ($rawline =~ /^\+ / && $rawline !~ /\+ +\*/ && $rawline !~ /:$/) {

Perhaps that's not an ideal test.
Maybe "&& $rawline !~ /^\+ \w+:/" is better.

The current test misidentify labels with comments:
drivers/net/tulip/interrupt.c: oom: /* Executed with RX ints disabled */




\
 
 \ /
  Last update: 2010-10-17 10:23    [W:1.996 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site