lkml.org 
[lkml]   [2010]   [Oct]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/3] fs/ceph/xattr.c: Use kasprintf
From
Date
On Sun, 2010-10-17 at 20:48 +0200, Julia Lawall wrote:
> Convert a sequence of kmalloc and memcpy to use kasprintf. The argument is
> checked for being a string by the presence of a previous call to strlen.
[]
> diff --git a/fs/ceph/xattr.c b/fs/ceph/xattr.c
[]
> @@ -716,10 +716,9 @@ int ceph_setxattr(struct dentry *dentry, const char *name,
>
> /* preallocate memory for xattr name, value, index node */
> err = -ENOMEM;
> - newname = kmalloc(name_len + 1, GFP_NOFS);
> + newname = kasprintf(GFP_NOFS, "%s", name);

This one is probably better converted to kmemdup
as name_len is already known and is used later
in the routine.

kstrdup is also a possibility.




\
 
 \ /
  Last update: 2010-10-17 20:57    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site