lkml.org 
[lkml]   [2010]   [Oct]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2.6.36-rc7 1/2] isdn/capi: unregister capictr notifier after init failure
Am 15.10.2010 14:42, Tejun Heo wrote:
> capidrv_init() could leave capictr notifier dangling after init
> failure. Fix it.

Good catch!

I assume David will pick these two up for net-next. Adding him to CC.

Acked-by: Jan Kiszka <jan.kiszka@web.de>

>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> ---
> drivers/isdn/capi/capidrv.c | 1 +
> 1 file changed, 1 insertion(+)
>
> Index: work/drivers/isdn/capi/capidrv.c
> ===================================================================
> --- work.orig/drivers/isdn/capi/capidrv.c
> +++ work/drivers/isdn/capi/capidrv.c
> @@ -2288,6 +2288,7 @@ static int __init capidrv_init(void)
>
> errcode = capi20_get_profile(0, &profile);
> if (errcode != CAPI_NOERROR) {
> + unregister_capictr_notifier(&capictr_nb);
> capi20_release(&global.ap);
> return -EIO;
> }


[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2010-10-16 13:03    [W:0.037 / U:3.104 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site