lkml.org 
[lkml]   [2010]   [Oct]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 04/14] arch/tile: change lower bound on syscall error return to -4095
Date
On Thursday 14 October 2010 21:14:29 Chris Metcalf wrote:
> Previously we were using -1023, which is fine for normal syscall
> error returns, but the common value in use for other platforms
> is -4095, and one Tilera-specific driver does use values in the
> -1100 range, so tickled this bug.

The patch is ok, but note that any value above starting at 512 is meant
as kernel internal, so funny things may happen if a driver goes
beyond that for errors returned to the user.

Better use just the predefined error codes if possible.

Arnd


\
 
 \ /
  Last update: 2010-10-14 23:25    [from the cache]
©2003-2011 Jasper Spaans