lkml.org 
[lkml]   [2010]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 0/4] memblock related fixes for -tip
 On 10/13/2010 03:06 PM, Yinghai Lu wrote:
> On 10/13/2010 01:03 PM, Jeremy Fitzhardinge wrote:
>>> a) Add an explicit interface to allocate bottoms-up, and have Xen use it
>>> because it needs it. This is appropriate if (and only if) the
>>> allocations in Xen aren't underneath a bunch of extra layers.
>> The allocation is done in find_early_table_space() in x86/mm/init.c, so
>> the allocation call itself can't be easily replaced, but I suppose some
>> of the parameters could be global and tweaked by Xen code, but that's
>> pretty ugly.
> we already have
> base = memblock_find_in_range(start, max_pfn_mapped<<PAGE_SHIFT,
> tables, PAGE_SIZE);
>
> so looks like xen have set max_pfn_mapped wrong?

The Xen code is setting the max_pfn_mapped correctly, but it is just
being overridden by:

max_pfn_mapped = KERNEL_IMAGE_SIZE >> PAGE_SHIFT;

in setup_arch() - and KERNEL_IMAGE_SIZE is hard-coded to 512MB...

How is this correct? Does kernel/head_64.S map everything up to 512MB
or something?

J


\
 
 \ /
  Last update: 2010-10-14 01:17    [W:0.084 / U:1.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site