lkml.org 
[lkml]   [2010]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] Serial: BUGFIX: uart_resume_port has an omitted condition.
From
On Wed, Oct 13, 2010 at 3:26 PM, Greg KH <gregkh@suse.de> wrote:
> On Wed, Oct 13, 2010 at 02:58:06PM +0900, MyungJoo Ham wrote:
>> When console_suspend_enabled == 0, console_stop() was not called at
>> suspend; thus, it does not need to call console_start() when resume.
>> Besides, calling console_start() without calling console_stop() before
>> had been incurring kernel hang with console_suspend_enabled == 0 in a
>> machine with drivers/serial/samsung.c and s5pc210.
>
> Is this a regression?  If so, from what working kernel?  Or has this
> always been this way?
>
> thanks,
>
> greg k-h
>


I don't think this is a regression to the previous version. Logically,
it's matching the console_stop()-console_start() pair.

Such hang in serial and its mitigation is observed in 2.6.36 at
arch/arm/mach-s5pv310 machines. In these machines, it hanged with
console_suspend_enabled == 0 every time.



Cheers!

- MyungJoo

--
MyungJoo Ham (함명주), Ph.D.
Mobile Software Platform Lab,
Digital Media and Communications (DMC) Business
Samsung Electronics
cell: 82-10-6714-2858
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-10-13 08:41    [W:0.068 / U:1.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site