| Date | Wed, 13 Oct 2010 07:36:43 -0400 | From | Christoph Hellwig <> | Subject | Re: [PATCH 07/18] fs: rework icount to be a locked variable |
| |
> - atomic_inc(&inode->i_count); > + spin_lock(&inode->i_lock); > + inode->i_ref++; > + spin_unlock(&inode->i_lock);
Why isn't this using iref?
> + spin_lock(&inode->i_lock); > + inode->i_ref++; > + spin_unlock(&inode->i_lock);
Same here and in a couple of others.
Hmm, I guess because the i_lock later covers other things around. But it still looks a bit weird.
Except for this stuff the patch looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
|