lkml.org 
[lkml]   [2010]   [Oct]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 07/18] fs: rework icount to be a locked variable
> -		atomic_inc(&inode->i_count);
> + spin_lock(&inode->i_lock);
> + inode->i_ref++;
> + spin_unlock(&inode->i_lock);

Why isn't this using iref?

> + spin_lock(&inode->i_lock);
> + inode->i_ref++;
> + spin_unlock(&inode->i_lock);

Same here and in a couple of others.

Hmm, I guess because the i_lock later covers other things around.
But it still looks a bit weird.

Except for this stuff the patch looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>


\
 
 \ /
  Last update: 2010-10-13 13:39    [W:0.243 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site