lkml.org 
[lkml]   [2010]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] ARM: allow, but warn, when issuing ioremap() on RAM
    From
    Date
    On Sat, 2010-10-09 at 17:45 +0100, Russell King - ARM Linux wrote:
    > On Sat, Oct 09, 2010 at 07:07:01PM +0300, Felipe Contreras wrote:
    > > On Sat, Oct 9, 2010 at 4:52 PM, Russell King - ARM Linux
    > > <linux@arm.linux.org.uk> wrote:
    > > > On Thu, Oct 07, 2010 at 12:44:22PM +0300, Felipe Contreras wrote:
    > > >> For issues related to this:
    > > >> http://article.gmane.org/gmane.linux.ports.arm.kernel/84454
    > > >
    > > > This one nicely shows some of the problems which can occur with the
    > > > memory type attributes - and this is not attributable to ioremap().
    > > >
    > > > ioremap() is used to map devices. It creates device memory type mappings.
    > > > If what you're mapping doesn't support device memory type mappings, then
    > > > accesses via an ioremap()'d region isn't going to work - as this guy is
    > > > observing.
    > > >
    > > > That's not because ioremap() is doing something wrong. It's doing what
    > > > it's meant to do. The use is wrong, and is completely unrelated to the
    > > > issue you've raised.
    > >
    > > Ok, I was confused by Catalin's comment which does point to ioremap()
    > > on normal RAM:
    > > http://article.gmane.org/gmane.linux.ports.arm.kernel/84504
    >
    > Me too - it doesn't appear to relate to the specified problem. You
    > don't want to map RAM as device nor strongly ordered, and we still
    > don't know what this "MMR" is.

    I don't know what MMR is either. But my comment is misleading, I think I
    was thinking about dma_alloc_coherent().

    We could to allow ioremap_wc() or ioremap_cached() to normal RAM but
    that's probably outside the scope of ioremap* (and it would require
    initial cache maintenance to remove potential dirty cache lines).

    --
    Catalin



    \
     
     \ /
      Last update: 2010-10-11 11:29    [W:0.024 / U:64.680 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site