lkml.org 
[lkml]   [2010]   [Oct]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] x86, setup: Check early serial console per string instead of one char
    On 10/11/2010 10:50 AM, Yinghai Lu wrote:
    >
    > Move out serial_putchar() calling out of putchar
    > Let puts() to call serial_putchar() directly.
    >
    > So only need to check early_serial_base per string.
    >
    > Signed-off-by: Yinghai Lu <yinghai@kernel.org>
    >

    This seems to add a bunch of code for zero benefit. Testing a global
    variable is zero cost compared to either a BIOS call or poking a serial
    port.

    -hpa


    \
     
     \ /
      Last update: 2010-10-11 20:21    [W:0.023 / U:0.628 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site