Messages in this thread | | | Date | Mon, 11 Oct 2010 11:19:24 -0700 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] x86, setup: Check early serial console per string instead of one char |
| |
On 10/11/2010 10:50 AM, Yinghai Lu wrote: > > Move out serial_putchar() calling out of putchar > Let puts() to call serial_putchar() directly. > > So only need to check early_serial_base per string. > > Signed-off-by: Yinghai Lu <yinghai@kernel.org> >
This seems to add a bunch of code for zero benefit. Testing a global variable is zero cost compared to either a BIOS call or poking a serial port.
-hpa
| |