lkml.org 
[lkml]   [2010]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 11/17] fs: Factor inode hash operations into functions
    On Wed, Sep 29, 2010 at 10:18:43PM +1000, Dave Chinner wrote:
    > From: Nick Piggin <npiggin@suse.de>
    >
    > Before we can replace the inode hash locking with a more scalable
    > mechanism, we need to remove external users of the inode_hash_lock.
    > Make it private by adding a function __remove_inode_hash that can be
    > called by filesystems instead of open-coding their own inode hash
    > removal operations.

    I like the factoring, but this changelog is misleading. At least in
    this series no new user of __remove_inode_hash appears, and I'm not sure
    where it would appear anyway. Just making the function global without
    actually exporting it is not helping external filesystems anyway. For
    now it can simply be made static.



    \
     
     \ /
      Last update: 2010-10-03 23:51    [W:5.523 / U:0.952 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site