Messages in this thread | | | Date | Fri, 01 Oct 2010 14:28:35 +0800 | From | Cong Wang <> | Subject | Re: [PATCH 1/4] Fix wrong source path in scripts/namespace.pl |
| |
On 10/01/10 13:56, Stephen Hemminger wrote: > On Thu, 30 Sep 2010 14:28:55 +0800 > Amerigo Wang<amwang@redhat.com> wrote: > >> File::Find will do chdir automatically, so we need to get >> the absolute patch with $File::Find::dir. >> >> Reported-by: Stephen Hemminger<shemminger@vyatta.com> >> Signed-off-by: Amerigo Wang<amwang@redhat.com> >> --- >> scripts/namespace.pl | 8 ++++---- >> 1 files changed, 4 insertions(+), 4 deletions(-) > > How did you test this? I tried your patches and when I run > it on a compiled kernel in a way that most developers would > do it: > $ make allmodconfig > $ make > $ ./scripts/namespace.pl
I use 'make namespacecheck'.
> > With your patch it still doesn't find the kernel source files. > I find it frustrating because my patch worked, yours didn't. > > -------- > No source file found for arch/x86/crypto/aes-i586-asm_32.o > No source file found for arch/x86/crypto/aes_glue.o ...
Actually, this shows it is working. :)
There are two reasons why you got so many of these:
1) You didn't do a 'make mrproper', so some source file may be deleted or renamed in git repo;
2) There are no path/to/foo.c for path/to/foo.o which is normal, we should add those files to exception list.
I got much fewer of such warning when I tested it.
| |