lkml.org 
[lkml]   [2010]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch] x86, apic: use 0x20 for the IRQ_MOVE_CLEANUP_VECTOR instead of 0x1f
On 01/08/2010 07:07 PM, Yinghai Lu wrote:
>> diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
>> index d5bfa29..5c090a1 100644
>> --- a/arch/x86/kernel/apic/io_apic.c
>> +++ b/arch/x86/kernel/apic/io_apic.c
>> @@ -1162,8 +1162,8 @@ __assign_irq_vector(int irq, struct irq_cfg *cfg, const struct cpumask *mask)
>> * Also, we've got to be careful not to trash gate
>> * 0x80, because int 0x80 is hm, kind of importantish. ;)
>> */
>> - static int current_vector = FIRST_DEVICE_VECTOR + VECTOR_OFFSET_START;
>> - static int current_offset = VECTOR_OFFSET_START % 8;
>> + static int current_vector = FIRST_DEVICE_VECTOR;
>> + static int current_offset = 0;
>> unsigned int old_vector;
>> int cpu, err;
>> cpumask_var_t tmp_mask;
>>
>
> looks like it returned to first version i suggested?
>
> http://lkml.org/lkml/2010/1/4/26
>
> maybe we can just kill FIRST_DEVICE_VECTOR...
>

As I already said, I really don't like reverting this bit.

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2010-01-09 04:33    [W:0.056 / U:0.200 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site