Messages in this thread | | | Date | Fri, 8 Jan 2010 16:43:51 -0800 | Subject | Re: [PATCH] Makefile: do not override LC_CTYPE | From | "H. Peter Anvin" <> |
| |
> H. Peter Anvin wrote: >> On 01/08/2010 04:09 PM, Masami Hiramatsu wrote: >>> Hi Michal, >>> >>> Michal Marek wrote: >>>> Setting LC_CTYPE=C breaks localized messages in some setups. With only >>>> LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for >>>> not >>>> so defined character classes and tolower()/toupper(). The former is >>>> not >>>> a big issue, because we can assume that e.g. [:alpha:] will always >>>> include a-zA-Z and we only ever process ASCII input. The latter seems >>>> only affect arch/sh/tools/gen-mach-types, which we can handle >>>> separately. >>> >>> Hmm, this also affects arch/x/tools/gen-insn-attr-x86.awk. >>> Could you also wrap it? >>> >> >> This is tolower/toupper()? Do there exist locales where tolower/toupper >> on ASCII input do weird things, or are we merely hypothesizing? > > Isn't it affect [A-Z] or [a-z]? If not, the patch good to me too. >
[A-Z][a-z] is what LC_COLLATE is about.
-hpa
| |