lkml.org 
[lkml]   [2010]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -mmotm] build fix for memcg-move-charges-of-anonymous-swap.patch
    On Thu, 7 Jan 2010 13:30:26 +0900
    KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:

    > On Thu, 7 Jan 2010 13:06:09 +0900
    > Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp> wrote:
    >
    > > build fix in !CONFIG_SWAP case.
    > >
    > > CC mm/memcontrol.o
    > > mm/memcontrol.c: In function 'is_target_pte_for_mc':
    > > mm/memcontrol.c:3648: error: implicit declaration of function 'mem_cgroup_count_swap_user'
    > > make[1]: *** [mm/memcontrol.o] Error 1
    > > make: *** [mm] Error 2
    > >
    > > Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
    > > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
    > > Signed-off-by: Daisuke Nishimura <nishimura@mxp.nes.nec.co.jp>
    >
    > Hmm, this doesn't seem include fix for CONFIG_CGROUP_MEM_RES_CTLR_SWAP=n
    > ==
    > static int is_target_pte_for_mc(struct vm_area_struct *vma,
    > unsigned long addr, pte_t ptent, union mc_target *target)
    > {
    > ....
    > else if (is_swap_pte(ptent)) {
    > ent = pte_to_swp_entry(ptent);
    > if (!move_anon || non_swap_entry(ent))
    > return 0;
    > usage_count = mem_cgroup_count_swap_user(ent, &page);
    > }
    > ==
    > At least, !do_swap_account check is necessary, I think.
    > I'm sorry if I miss something...
    >

    Get follwoing after this patch with !CONFIG_SWAP case.
    ==
    mm/built-in.o: In function `is_target_pte_for_mc':
    /home/kamezawa/Kernel/ref-mmotm/mm/memcontrol.c:3985: undefined reference to `mem_cgroup_count_swap_user'


    I think !do_swap_count check in is_target_pte_for_mc() should be added.

    Thanks,
    -Kame




    \
     
     \ /
      Last update: 2010-01-07 06:13    [W:0.025 / U:38.492 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site