lkml.org 
[lkml]   [2010]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [GIT PULL] Please pull NFS client bugfixes....


On Thu, 7 Jan 2010, Trond Myklebust wrote:
>
> I don't think anyone has been advocating doing the revalidation _after_
> the call to mmap_region(). All I want is to be able to do it as part of
> the mmap() syscall. It would be quite OK to add a ->pre_mmap() (which is
> what I believe Peter's patches do).

->pre_mmap is better, but not obviously so. We'd have to call ->pre_mmap()
so _long_ before the mmap that it might be that the mmap never happens at
all (due to errors happening later).

Sounds like that would work in your particular case, though.

However, I still suspect that the lock inversion problem can probably be
fixed without any of that at all. Maybe you can just break the chain
somewhere else. I've not actually seen the lockdep chain, so I don't know
the deails. Pointers?

Linus


\
 
 \ /
  Last update: 2010-01-08 02:33    [from the cache]
©2003-2011 Jasper Spaans