Messages in this thread | | | Date | Thu, 7 Jan 2010 16:39:27 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [RFC][PATCH 6/8] mm: handle_speculative_fault() |
| |
On Fri, 8 Jan 2010, KAMEZAWA Hiroyuki wrote: > > Hmm, do_brk() sometimes unmap conflicting mapping. Isn't it be a problem ?
No. For two reasons:
- sys_brk() doesn't actually do that (see the "find_vma_intersection()" call). I'm not sure why do_brk() does, but it might have to do with execve().
- the patch I sent out just falls back to the old code if it finds something fishy, so it will do whatever do_brk() does regardless.
(Yes, brk() does unmap the old brk for the _shrinking_ case, of course. Again, the patch I sent just falls back to the old behavior in that case)
Linus
| |