lkml.org 
[lkml]   [2010]   [Jan]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 6/8] mm: handle_speculative_fault()


On Fri, 8 Jan 2010, KAMEZAWA Hiroyuki wrote:
>
> Hmm, do_brk() sometimes unmap conflicting mapping. Isn't it be a problem ?

No. For two reasons:

- sys_brk() doesn't actually do that (see the "find_vma_intersection()"
call). I'm not sure why do_brk() does, but it might have to do with
execve().

- the patch I sent out just falls back to the old code if it finds
something fishy, so it will do whatever do_brk() does regardless.

(Yes, brk() does unmap the old brk for the _shrinking_ case, of course.
Again, the patch I sent just falls back to the old behavior in that case)

Linus



\
 
 \ /
  Last update: 2010-01-08 01:43    [W:4.681 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site