Messages in this thread | | | Date | Thu, 07 Jan 2010 14:15:11 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH]drivers/ata/libata-eh.c:1509 unneeded memset() |
| |
On 12/30/2009 05:59 PM, René Bolldorf wrote: > We don't need this ;-). > > Best regards René Bolldorf & a happy new year in advance. > > --- ./drivers/ata/libata-eh.c 2009-12-30 23:44:05.578988545 +0100 > +++ ./drivers/ata/libata-eh.c 2009-12-30 23:45:06.991987607 +0100 > @@ -1505,9 +1505,6 @@ static unsigned int atapi_eh_request_sen > > DPRINTK("ATAPI request sense\n"); > > - /* FIXME: is this needed? */ > - memset(sense_buf, 0, SCSI_SENSE_BUFFERSIZE);
I need a little bit more detail than an unqualified statement... Did you audit all paths leading to this code point?
Jeff
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |