Messages in this thread Patch in this message | | | Date | Thu, 7 Jan 2010 08:04:02 -0800 | From | Randy Dunlap <> | Subject | Re: mmotm 2010-01-06-14-34 uploaded (squashfs+lib/decomp) |
| |
On Wed, 06 Jan 2010 23:01:47 -0500 Valdis.Kletnieks@vt.edu wrote:
> On Wed, 06 Jan 2010 22:48:16 EST, Valdis.Kletnieks@vt.edu said: > > > Building with CONFIG_SQUASHFS=m, CONFIG_SQUASHFS_LZMA=y , > > and CONFIG_DECOMPRESS_LZMA=n fails: > > > Looks like a missing select/depends for DECOMPRESS_LZMA. Somebody else can > > decide which it should be... > > Digging further: > > x Symbol: DECOMPRESS_LZMA [=n] x > x Selected by: RD_LZMA [=n] && BLK_DEV_INITRD [=y] || SQUASHFS_LZMA [=y x > > How the heck did this happen? Looks like a SELECT *is* there but it's > not firing??!?
I saw this build error in linux-next and sent a patch for it -- it's below. However, it doesn't appear to be exactly the same config as yours.
--- From: Randy Dunlap <randy.dunlap@oracle.com>
When CONFIG_SQUASHFS=m and CONFIG_DECOMPRESS_LZMA=m, decompress_lzma is built but then discarded from the library because no built-in code uses it, so change it from a lib- to an obj- to force it to be kept in the library.
ERROR: "unlzma" [fs/squashfs/squashfs.ko] undefined!
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com> Cc: Phillip Lougher <phillip@lougher.demon.co.uk> Cc: Michal Marek <mmarek@suse.cz> --- lib/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-next-20100101.orig/lib/Makefile +++ linux-next-20100101/lib/Makefile @@ -69,7 +69,7 @@ obj-$(CONFIG_LZO_DECOMPRESS) += lzo/ lib-$(CONFIG_DECOMPRESS_GZIP) += decompress_inflate.o lib-$(CONFIG_DECOMPRESS_BZIP2) += decompress_bunzip2.o -lib-$(CONFIG_DECOMPRESS_LZMA) += decompress_unlzma.o +obj-$(CONFIG_DECOMPRESS_LZMA) += decompress_unlzma.o obj-$(CONFIG_TEXTSEARCH) += textsearch.o obj-$(CONFIG_TEXTSEARCH_KMP) += ts_kmp.o
| |