lkml.org 
[lkml]   [2010]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH 10/11] tracing: Use appropriate perl constructs in recordmcount.pl
    From: Wolfram Sang <w.sang@pengutronix.de>

    Modified recordmcount.pl to use perl constructs that are still
    understandable by C hackers that are not perl programmers.

    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    LKML-Reference: <1262724082-9517-1-git-send-email-w.sang@pengutronix.de>
    Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
    ---
    scripts/recordmcount.pl | 29 +++++++++++------------------
    1 files changed, 11 insertions(+), 18 deletions(-)

    diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl
    index 5de12c7..545fe71 100755
    --- a/scripts/recordmcount.pl
    +++ b/scripts/recordmcount.pl
    @@ -136,13 +136,14 @@ my %text_sections = (
    ".text.unlikely" => 1,
    );

    -$objdump = "objdump" if ((length $objdump) == 0);
    -$objcopy = "objcopy" if ((length $objcopy) == 0);
    -$cc = "gcc" if ((length $cc) == 0);
    -$ld = "ld" if ((length $ld) == 0);
    -$nm = "nm" if ((length $nm) == 0);
    -$rm = "rm" if ((length $rm) == 0);
    -$mv = "mv" if ((length $mv) == 0);
    +# Note: we are nice to C-programmers here, thus we skip the '||='-idiom.
    +$objdump = 'objdump' if (!$objdump);
    +$objcopy = 'objcopy' if (!$objcopy);
    +$cc = 'gcc' if (!$cc);
    +$ld = 'ld' if (!$ld);
    +$nm = 'nm' if (!$nm);
    +$rm = 'rm' if (!$rm);
    +$mv = 'mv' if (!$mv);

    #print STDERR "running: $P '$arch' '$objdump' '$objcopy' '$cc' '$ld' " .
    # "'$nm' '$rm' '$mv' '$inputfile'\n";
    @@ -194,12 +195,8 @@ sub check_objcopy
    }
    }

    -if ($arch eq "x86") {
    - if ($bits == 64) {
    - $arch = "x86_64";
    - } else {
    - $arch = "i386";
    - }
    +if ($arch eq 'x86') {
    + $arch = ($bits == 64) ? 'x86_64' : 'i386';
    }

    #
    @@ -476,11 +473,7 @@ while (<IN>) {
    $read_headers = 0;

    # Only record text sections that we know are safe
    - if (defined($text_sections{$1})) {
    - $read_function = 1;
    - } else {
    - $read_function = 0;
    - }
    + $read_function = defined($text_sections{$1});
    # print out any recorded offsets
    update_funcs();

    --
    1.6.5



    \
     
     \ /
      Last update: 2010-01-07 00:17    [W:0.021 / U:30.692 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site