lkml.org 
[lkml]   [2010]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fs: O_* bit numbers uniqueness check
Le 06/01/2010 07:55, Wu Fengguang a écrit :
> The O_* bit numbers are defined in 20+ arch/*, and hence can silently
> overlap. Add a boot time check to ensure the uniqueness as suggested
> by David Miller.
>
> CC: David Miller <davem@davemloft.net>
> CC: Stephen Rothwell <sfr@canb.auug.org.au>
> CC: Al Viro <viro@zeniv.linux.org.uk>
> CC: Christoph Hellwig <hch@infradead.org>
> CC: Eric Paris <eparis@redhat.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@intel.com>
> ---
> {
> + /* please add new bits here to ensure allocation uniqueness */
> + BUG_ON(20 != hweight32(
> + O_RDONLY | O_WRONLY | O_RDWR |
> + O_CREAT | O_EXCL | O_NOCTTY |
> + O_TRUNC | O_APPEND | O_NONBLOCK |
> + O_SYNC | FASYNC | O_DIRECT |
> + O_LARGEFILE | O_DIRECTORY | O_NOFOLLOW |
> + O_NOATIME | O_CLOEXEC | O_RANDOM |
> + FMODE_EXEC | FMODE_NONOTIFY));
> +

I cannot test it, but given O_RDONLY is 0, are you sure 20 bits are actually set ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-01-06 08:19    [W:0.955 / U:0.308 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site