Messages in this thread | | | From | Roland McGrath <> | Subject | Re: s390 && user_enable_single_step() (Was: odd utrace testing results on s390x) | Date | Wed, 6 Jan 2010 13:15:36 -0800 (PST) |
| |
> > then the test-case from 6580807da14c423f0d0a708108e6df6ebc8bc83d > > fails. This probably means that copy_process()->user_disable_single_step() > > is not enough to clear the "this task wants single-stepping" copied > > from parent. > > user_disable_single_step() does not remove the TIF_SINGLE_STEP bit from the > forked task. Perhaps we should just clear the bit in the function.
If that were to fix this test case, I think it would be incidental rather than meaning the right thing. The "this task wants single-stepping" state should not have anything to do with TIF_SINGLE_STEP. It means "this task recently had single-stepping", which is a separate moving part.
Thanks, Roland
| |