[lkml]   [2010]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[patch] x86, irq: check move_in_progress before freeing the vector mapping
    x86 folks, please queue this fix for 2.6.33.


    From: Suresh Siddha <>
    Subject: [patch] x86, irq: check move_in_progress before freeing the vector mapping

    With the recent irq migration fixes (post 2.6.32), Gary Hade has noticed
    "No IRQ handler for vector" messages during the 2.6.33-rc1 kernel boot on IBM
    AMD platforms and root caused the issue to this commit:

    > commit 23359a88e7eca3c4f402562b102f23014db3c2aa
    > Author: Suresh Siddha <>
    > Date: Mon Oct 26 14:24:33 2009 -0800
    > x86: Remove move_cleanup_count from irq_cfg

    As part of this patch, we have removed the move_cleanup_count check
    in smp_irq_move_cleanup_interrupt(). With this change, we can run into a
    situation where an irq cleanup interrupt on a cpu can cleanup the vector
    mappings associated with multiple irqs, of which one of the irq's migration
    might be still in progress. As such when that irq hits the old cpu, we get
    the "No IRQ handler" messages.

    Fix this by checking for the irq_cfg's move_in_progress and if the move
    is still in progress delay the vector cleanup to another irq cleanup
    interrupt request (which will happen when the irq starts arriving at the
    new cpu destination).

    Reported-and-tested-by: Gary Hade <>
    Signed-off-by: Suresh Siddha <>
    Cc: Eric W. Biederman <>

    diff --git a/arch/x86/kernel/apic/io_apic.c b/arch/x86/kernel/apic/io_apic.c
    index de00c46..53243ca 100644
    --- a/arch/x86/kernel/apic/io_apic.c
    +++ b/arch/x86/kernel/apic/io_apic.c
    @@ -2434,6 +2434,13 @@ asmlinkage void smp_irq_move_cleanup_interrupt(void)
    cfg = irq_cfg(irq);

    + /*
    + * Check if the irq migration is in progress. If so, we
    + * haven't received the cleanup request yet for this irq.
    + */
    + if (cfg->move_in_progress)
    + goto unlock;
    if (vector == cfg->vector && cpumask_test_cpu(me, cfg->domain))
    goto unlock;

     \ /
      Last update: 2010-01-06 19:59    [W:0.023 / U:2.896 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site