lkml.org 
[lkml]   [2010]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] [1/9] Add rcustring ADT for RCU protected strings v2
    On Mon, Jan 04, 2010 at 09:32:52PM -0800, Paul E. McKenney wrote:
    > > +/*
    > > + * Get a local private copy of a RCU protected string.
    > > + * Mostly useful to get a string that is stable while sleeping.
    > > + * Caller must free returned string.
    > > + */
    > > +char *access_rcu_string(char **str, int size, gfp_t gfp)
    > > +{
    > > + char *copy = kmalloc(size, gfp);
    > > + if (!str)
    > > + return NULL;
    > > + rcu_read_lock();
    > > + strlcpy(copy, rcu_dereference(*str), size);
    >
    > What if "str" is non-NULL, but "*str" is NULL? Or is that disallowed
    > somehow?

    I would consider it disallowed, all the strings have some default value.
    Empty string would be ""

    If we allowed it the caller couldn't easily distingush error from expected NULL.

    -Andi

    --
    ak@linux.intel.com -- Speaking for myself only.


    \
     
     \ /
      Last update: 2010-01-05 11:51    [W:0.025 / U:0.160 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site