Messages in this thread | | | Date | Tue, 5 Jan 2010 15:35:27 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [RFC][PATCH 6/8] mm: handle_speculative_fault() |
| |
On Tue, 5 Jan 2010, Peter Zijlstra wrote: > > While looking at that code, I found the placement of might_sleep() a tad > confusing, I'd expect that to be in fput() since that is the regular > entry point (all except AIO, which does crazy things).
I think it's the crazy AIO thing that is one of the reasons for doing it in __fput. If it's just in fput() it covers the _normal_ cases better, but I doubt that those were the primary worry ;).
Linus
| |