Messages in this thread | | | Date | Tue, 5 Jan 2010 15:20:18 -0800 | From | Greg KH <> | Subject | Re: [PATCH] [4/12] SYSFS: Add sysfs_add/remove_files utility functions |
| |
On Tue, Jan 05, 2010 at 05:21:06PM +0100, Andi Kleen wrote: > On Tue, Jan 05, 2010 at 06:53:09AM -0800, Greg KH wrote: > > On Tue, Jan 05, 2010 at 12:48:01PM +0100, Andi Kleen wrote: > > > > > > Adding/Removing a whole array of attributes is very common. Add a standard > > > utility function to do this with a simple function call, instead of > > > requiring drivers to open code this. > > > > Hm, that is what the sysfs_create_group(), sysfs_update_group(), and > > sysfs_remove_group() functions are for. We don't need to add any new > > functions that do the same thing, right? > > Hmm, originally I didn't use them because they created a sub-directory, > but I see now that's optional. > > Still the input format is completely different and doesn't fit into > the ->attrs list that are used elsewhere (e.g. for the sysdev_classes) > So using groups would need a lot of restructuring.
Argh, you are right.
Damm I hate the sysdev code, I need to dig up my "make drivers bind to multiple devices" tree and get it up to date so we can just delete the things completly and move to a "real" struct device instead.
> Also similar code as I have is already in a lot of places, which > over time will be converted. So it's definitely less code than > before.
Ok, good point, I'll queue this up, and hopefully be able to delete it all in 6-8 months again :)
thanks,
greg k-h
| |