Messages in this thread | | | Date | Tue, 5 Jan 2010 10:56:37 -0800 (PST) | From | Linus Torvalds <> | Subject | Re: [RFC][PATCH 6/8] mm: handle_speculative_fault() |
| |
On Tue, 5 Jan 2010, Christoph Lameter wrote: > > There will not be much spinning. The cacheline will be held exclusively by > one processor. A request by other processors for shared access to the > cacheline will effectively stop the execution on those processors until > the cacheline is available.
AT WHICH POINT THEY ALL RACE TO GET IT TO SHARED MODE, only to then have one of them actually see that it got a ticket!
Don't you see the problem? The spinlock (with ticket locks) essentially does the "xadd" atomic increment anyway, but then it _waits_ for it. All totally pointless, and all just making for problems, and wasting CPU time and causing more cross-node traffic.
In contrast, a native xadd-based rwsem will basically do the atomic increment (that ticket spinlocks also do) and then just go on with its life. Never waiting for all the other CPU's to also do their ticket spinlocks.
The "short critical region" you talk about is totally meaningless, since the contention will mean that everybody is waiting and hitting that cacheline for a long time regardless - they'll be waiting for O(n) _other_ CPU's to get the lock first!
Linus
| |