Messages in this thread Patch in this message | | | From | Wolfram Sang <> | Date | Tue, 5 Jan 2010 19:27:52 +0100 | Subject | [PATCH 2/2] tracing/recordmount.pl: use apropriate perl-constructs |
| |
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de> --- scripts/recordmcount.pl | 33 ++++++++++++--------------------- 1 files changed, 12 insertions(+), 21 deletions(-)
diff --git a/scripts/recordmcount.pl b/scripts/recordmcount.pl index 5de12c7..59b73b9 100755 --- a/scripts/recordmcount.pl +++ b/scripts/recordmcount.pl @@ -136,13 +136,13 @@ my %text_sections = ( ".text.unlikely" => 1, ); -$objdump = "objdump" if ((length $objdump) == 0); -$objcopy = "objcopy" if ((length $objcopy) == 0); -$cc = "gcc" if ((length $cc) == 0); -$ld = "ld" if ((length $ld) == 0); -$nm = "nm" if ((length $nm) == 0); -$rm = "rm" if ((length $rm) == 0); -$mv = "mv" if ((length $mv) == 0); +$objdump ||= 'objdump'; +$objcopy ||= 'objcopy'; +$cc ||= 'gcc'; +$ld ||= 'ld'; +$nm ||= 'nm'; +$rm ||= 'rm'; +$mv ||= 'mv'; #print STDERR "running: $P '$arch' '$objdump' '$objcopy' '$cc' '$ld' " . # "'$nm' '$rm' '$mv' '$inputfile'\n"; @@ -163,9 +163,8 @@ my $section_type; # Section header plus possible alignment command my $can_use_local = 0; # If we can use local function references # Shut up recordmcount if user has older objcopy -my $quiet_recordmcount = ".tmp_quiet_recordmcount"; -my $print_warning = 1; -$print_warning = 0 if ( -f $quiet_recordmcount); +my $quiet_recordmcount = '.tmp_quiet_recordmcount'; +my $print_warning = (! -f $quiet_recordmcount); ## # check_objcopy - whether objcopy supports --globalize-symbols @@ -194,12 +193,8 @@ sub check_objcopy } } -if ($arch eq "x86") { - if ($bits == 64) { - $arch = "x86_64"; - } else { - $arch = "i386"; - } +if ($arch eq 'x86') { + $arch = ($bits == 64) ? 'x86_64' : 'i386'; } # @@ -476,11 +471,7 @@ while (<IN>) { $read_headers = 0; # Only record text sections that we know are safe - if (defined($text_sections{$1})) { - $read_function = 1; - } else { - $read_function = 0; - } + $read_function = defined($text_sections{$1}); # print out any recorded offsets update_funcs(); -- 1.6.3.3
| |