lkml.org 
[lkml]   [2010]   [Jan]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] [5/12] SYSFS: Add attribute array to sysdev classes
On Tue, Jan 05, 2010 at 12:48:02PM +0100, Andi Kleen wrote:
>
> Add a attribute array that is automatically registered and unregistered
> to struct sysdev_class. This is similar to what struct class has.
>
> A lot of drivers add list of attributes, so it's better to do
> this easily in the common sysdev layer.
>
> This adds a new field to struct sysdev_class. I audited the
> whole tree and there are no dynamically allocated sysdev classes,
> so this is fully compatible.

I agree, this should be done, but can you use an attribute group
instead, like the driver core does? That way you don't need the new
function that you created that duplicates that logic :)

thanks,

greg k-h


\
 
 \ /
  Last update: 2010-01-05 16:05    [W:0.220 / U:0.332 seconds]
©2003-2011 Jasper Spaans. Advertise on this site