Messages in this thread | | | Date | Tue, 5 Jan 2010 05:52:24 -0800 | From | Arjan van de Ven <> | Subject | Re: strict copy_from_user checks issues? |
| |
On Tue, 5 Jan 2010 14:45:25 +0100 Arnd Bergmann <arnd@arndb.de> wrote: > > I think it will get inlined on 32 bit machines or without > CONFIG_COMPAT, but not when CONFIG_COMPAT is enabled, because then > there are two call-sites.
one of them is buggy it seems; it passes in a shorter length, but there is no code in sight that makes sure that the end of the structure (the difference between the shorter and full length one) gets initialized to, say, zeros rather than stack garbage. So looks like there is at least a bug there.
Would be nice if the copy (+ clear) would be pulled to the two callers I suspect... at which point the warning will go away too as a side effect.
-- Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org
| |