lkml.org 
[lkml]   [2010]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
DateTue, 5 Jan 2010 00:14:24 +0000
FromAlan Cox <>
SubjectRe: [PATCH] [4/6] kfifo: add kfifo_out_peek
> > Bloat is going to be a big issue if its macro and all the serial/tty
> > stuff switches to it. Please keep the bytewise one none macro - even if
> > its a lib/foo.c file that simply uses the macros to produce the existing
> > new API.
>
> Nope, currently the bytewise is the special case. Most of the user of
> kfifo try to store other type then bytes in a fifo.

If the tty layer switches to it then the bytewise one will dominately
quite rapidly as it can replace the uart_circ stuff

> The new macro based kfifo does not bloat the code, the opposite is the
> truth. I checked the assembler output on intel and ppc and the generated
> code is smaller and better.

Thats excellent



\
 
 \ /
  Last update: 2010-01-05 01:13    [from the cache]
©2003-2010