lkml.org 
[lkml]   [2010]   [Jan]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drivers/net/defxx.c: use %pM to show MAC address
On Wed, 30 Dec 2009, H Hartley Sweeten wrote:

> Use the %pM kernel extension to display the MAC address.
>
> The only difference in the output is that the MAC address is
> shown in the usual colon-separated hex notation.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: David S. Miller <davem@davemloft.net>

Nack. While I appreciate your effort, the FDDI standard defines opposite
bit-ordering for MAC addresses written in the dash-separated and the
colon-separated hexadecimal notation, which makes your change invalid,
sorry (you'd have to bit-swap them too and that would make addresses
counter-intuitive). Please note that `ifconfig' consistently uses the
dash-separated notation for FDDI interfaces too (I haven't checked other
tools like those in the "iproute" package; they may be buggy).

[I'd appreciate to be CCed on patch submissions to code I claim
maintenance of too.]

Maciej


\
 
 \ /
  Last update: 2010-01-04 19:53    [W:1.627 / U:0.000 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site