Messages in this thread | | | Date | Mon, 4 Jan 2010 08:44:56 -0500 | From | Konrad Rzeszutek Wilk <> | Subject | Re: [PATCH 02/29] x86/pci: intel ioh bus num reg accessing fix |
| |
On Sun, Jan 03, 2010 at 07:04:40PM -0800, Yinghai Lu wrote: > it is above 0x100, so if mmconf is not enable, need to skip it > > Reported-by: Jens Axboe <jens.axboe@oracle.com> > Signed-off-by: Yinghai Lu <yinghai@kernel.org> > --- > arch/x86/pci/intel_bus.c | 4 ++++ > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/arch/x86/pci/intel_bus.c b/arch/x86/pci/intel_bus.c > index b7a55dc..baf283a 100644 > --- a/arch/x86/pci/intel_bus.c > +++ b/arch/x86/pci/intel_bus.c > @@ -49,6 +49,10 @@ static void __devinit pci_root_bus_res(struct pci_dev *dev) > u64 mmioh_base, mmioh_end; > int bus_base, bus_end; > > + /* some sys doesn't get mmconf enabled */ > + if (dev->cfg_size < 0x200)
Here we check under the 512 index.. but the comment states that the check should be above 256 index? Should the comment say "it is above 0x200, so if mmconf.."?
| |