lkml.org 
[lkml]   [2010]   [Jan]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Shaohui,

Some style nitpicks..

> #ifdef CONFIG_MEMORY_HOTPLUG
> +/**

Should use /* here.

> + * After memory hotplug, the variable max_pfn, max_low_pfn and high_memory will
> + * be affected, it will be updated in this function.
> + */
> +static inline void __meminit update_end_of_memory_vars(u64 start,

The "inline" and "__meminit" are both redundant here.

> + max_low_pfn = max_pfn = end_pfn;

One assignment per line is preferred.

Thanks,
Fengguang



\
 
 \ /
  Last update: 2010-02-01 05:44    [W:3.930 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site