lkml.org 
[lkml]   [2010]   [Jan]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: drm_vm.c:drm_mmap: possible circular locking dependency detected
From
Date
ebiederm@xmission.com (Eric W. Biederman) writes:

> What to do about it is another question. It has just recently come to my
> attention that we have more events like this

In the specific case of serio what gets us in trouble is
the call to sysfs_remove_group.

If instead of independent calls to sysfs_create_group/sysfs_remove_group,
you could move the groups into a list on dev->groups than we could solve
two problems.

- Userspace would see all of the attributes when the hotplug event is
fired remove races.

- We would not hold serio->drv_mutex over sysfs_remove_group so there
would not be a possible deadlock on device removal.

Does that change sound possible?

Eric




\
 
 \ /
  Last update: 2010-01-03 12:17    [W:1.642 / U:0.228 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site