Messages in this thread | | | Date | Fri, 29 Jan 2010 18:18:57 -0800 | From | Philip Langdale <> | Subject | Re: [PATCH v3] port ricoh_mmc to pci quirk |
| |
On Sat, 30 Jan 2010 00:10:33 +0200 Maxim Levitsky <maximlevitsky@gmail.com> wrote:
> Well, I have nothing against this, but, even Linus himself stated that > he dislikes broken printk lines. > > I also noticed that some DECLARE_FIXUP in this file are longer that > 80, and since breaking this doesn't add any value, I thought that is > ok. Remember that main purpose of 80 char limit is to make code > simpler. > > However, I don't really care if you insist.
I don't want to be obnoxious either - if no one else is concerned about the lines, I won't kick up a fuss.
And thanks for sticking with this patch - I want to see it in soon too; I'd like to sort out the new PCI-e Ricoh parts which are going to need a new magic sequence.
--phil
| |