Messages in this thread | | | Date | Fri, 29 Jan 2010 17:14:53 -0500 | From | Christoph Hellwig <> | Subject | Re: [patch 01/10] smbfs: Convert server->sem to mutex |
| |
On Fri, Jan 29, 2010 at 08:38:34PM -0000, Thomas Gleixner wrote: > The semaphore server->sem is used as mutex. Rename it to server->mutex > and convert it to a real mutex. > > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Cc: Al Viro <viro@zeniv.linux.org.uk> > Cc: Jeff Layton <jlayton@redhat.com> > Cc: Steve French <sfrench@us.ibm.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
> static inline int > smb_lock_server_interruptible(struct smb_sb_info *server) > { > - return down_interruptible(&(server->sem)); > + return mutex_lock_interruptible(&server->mutex); > } > > static inline void > smb_lock_server(struct smb_sb_info *server) > { > - down(&(server->sem)); > + mutex_lock(&server->mutex); > } > > static inline void > smb_unlock_server(struct smb_sb_info *server) > { > - up(&(server->sem)); > + mutex_unlock(&server->mutex); > }
Eventually someone should also kill this useless wrappers, but let's do one thing at a time for now.
| |