Messages in this thread |  | | | Date | Fri, 29 Jan 2010 13:11:35 -0800 (PST) | | From | David Rientjes <> | | Subject | Re: [PATCH v3] oom-kill: add lowmem usage aware oom kill handling |
| |
On Sat, 30 Jan 2010, KAMEZAWA Hiroyuki wrote:
> If so, all heuristics other than vm_size should be purged, I think.
I don't recall anybody disagreeing about removing some of the current heuristics, but there is value to those beyond simply total_vm: we want to penalize tasks that do not share any mems_allowed with the triggering task, for example, otherwise it can lead to needless oom killing. Many people believe we should keep the slight penalty for superuser tasks over regular user tasks, as well.
Auditing the badness() function is a worthwhile endeavor and I think you'd be most successful if you tweaked the various penalties (runtime, nice, capabilities, etc) to reflect how much each is valued in terms of VM size, the baseline. I doubt anybody would defend simply dividing by 4 or multiplying by 2 being scientific.
|  |