lkml.org 
[lkml]   [2010]   [Jan]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 01/06] ARM: SuperH Mobile ARM, sh7367 and G3EVM support
From
On Fri, Jan 29, 2010 at 7:08 AM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> The entries in this choice menu are sorted by option text - please
> place your new option appropriately to avoid conflicts.

Ok, will make sure it gets sorted properly.

>> +static struct sh_timer_config cmt10_platform_data = {
>> +     .name = "CMT10",
>> +     .channel_offset = 0x10,
>> +     .timer_bit = 0,
>> +     .clk = "r_clk",
>
> I guess you can't do a lot about this because of arch/sh, but over in ARM
> land, we use clkdev to get the clock primerily by the device name rather
> than a string passed around; this is how the clk API is meant to be used.

At this early stage there is not so much to do. When I get around to
implement the clock framework and runtime pm for SuperH Mobile ARM
then I'll have a close look at clkdev.

I'll update and resend these patches next week.

Thanks!

/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2010-01-29 12:29    [from the cache]
©2003-2011 Jasper Spaans