Messages in this thread | | | Date | Thu, 28 Jan 2010 10:44:48 -0500 | From | Don Zickus <> | Subject | Re: [PATCH 3/3] [RFC] nmi_watchdog: config option to enable new nmi_watchdog |
| |
On Thu, Jan 28, 2010 at 03:54:54PM +0100, Peter Zijlstra wrote: > On Wed, 2010-01-27 at 15:03 -0500, Don Zickus wrote: > > These are the bits that enable the new nmi_watchdog and safely isolate the > > old nmi_watchdog. Only one or the other can run, not both at the same > > time. > > perf disables the lapic watchdog when it wants the pmu, so there > shouldn't be a problem having both built in.
Yes it does disable but does not prevent nmi_watchdog_tick from running nor the /proc interface from being loaded. So perhaps my description isn't very good. The idea with the new watchdog was to re-use some of the bits of the old one, but having them both compiled in seemed to stomp on each other. That is what I was trying to prevent.
I can certainly change the behaviour, just makes the code a little more messy I think.
Cheers, Don
| |