lkml.org 
[lkml]   [2010]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Generic PS/2 mouse detected on Fujitsu Lifebook B-Series model laptop instead of LBPS/2 Fujitsu Lifebook TouchScreen
On Wed, Jan 27, 2010 at 03:55:14PM -0800, Andrew Morton wrote:
> (suitable cc's added)
>
> On Mon, 25 Jan 2010 16:12:43 +0000
> jon - <crayzeejon@gmail.com> wrote:
>
> > From: Jon Dodgson <crayzeejon@gmail.com>
> >
> > Fix Detection of Lifebook B-Series Laptop touch screen with DMI
> > product Name string 'Lifebook B Series'
> >
> > Signed-off-by: Jon Dodgson <crayzeejon@gmail.com>
> >
> > ---
> > diff -Nurb linux-2.6.26.2/drivers/input/mouse/lifebook.c
> > linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c
> > --- linux-2.6.26.2/drivers/input/mouse/lifebook.c 2008-08-06
> > 17:19:01.000000000 +0100
> > +++ linux-2.6.26.2_patched/drivers/input/mouse/lifebook.c 2010-01-25
> > 02:56:41.000000000 +0000
> > @@ -51,6 +51,12 @@
> > {
> > .ident = "LifeBook B",
> > .matches = {
> > + DMI_MATCH(DMI_PRODUCT_NAME, "Lifebook B Series"),
> > + },
> > + },
> > + {
> > + .ident = "LifeBook B",
> > + .matches = {
> > DMI_MATCH(DMI_PRODUCT_NAME, "LifeBook B Series"),
> > },
> > },
>
> So the problem is "LifeBook" versus "Lifebook"? These matches are
> case-sensitive?

Yep. And trust to the BIOS writers wil fill this data with as many
permutations as possible.

>
> I don't know what kernel you were patching, but current kernels no
> longer have the ".ident" initialisation in that table. If it _was_
> still there then I'd wonder why you set the ident to "LifeBook B"
> rather than "Lifebook B".

Ident is just for information purposes only (and is was not used by
input that's why it was removed.

>
> Your email client wordwrapped the patch and replaced its tabs with
> spaces.

Yeah ;( Anyway, I ahve it now, thanks.

--
Dmitry


\
 
 \ /
  Last update: 2010-01-28 01:19    [W:0.036 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site