lkml.org 
[lkml]   [2010]   [Jan]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: + drivers-block-floppyc-remove-copyin-copyout-and-ecall-macros.patch added to -mm tree
FromJoe Perches <>
DateWed, 27 Jan 2010 06:53:13 -0800
On Wed, 2010-01-27 at 10:43 +0100, Jiri Slaby wrote:
> On 01/27/2010 01:37 AM, akpm@linux-foundation.org wrote:
> > @@ -3145,7 +3136,9 @@ static inline int raw_cmd_copyout(int cm
> > - COPYOUT(*ptr);
> > + ret = copy_to_user((void __user *)param, ptr, sizeof(*ptr));
> > + if (ret)
> > + return -EFAULT;
[]
> > - COPYIN(*ptr);
> > + ret = copy_from_user(ptr, (void __user *)param, sizeof(*ptr));
>
> Actually the casts are not needed anymore, are they?

There's still some char/void silliness.
It certainly could be improved/removed.

Do feel free to submit patches with your
desired level of changelog prolixity.

cheers, Joe



\
 
 \ /
  Last update: 2010-01-27 15:55    [from the cache]
©2003-2010