Messages in this thread | | | Date | Wed, 27 Jan 2010 10:44:55 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] tools/perf/perf.c: Clean up trivial style issues. |
| |
Em Wed, Jan 27, 2010 at 12:59:42PM +0100, Ingo Molnar escreveu: > > * Arnaldo Carvalho de Melo <acme@infradead.org> wrote: > > > Em Sun, Jan 24, 2010 at 06:21:46PM -0500, Thiago Farina escreveu: > > > Checked with: > > > ./../scripts/checkpatch.pl --terse --file perf.c > > > > > > perf.c:51: ERROR: open brace '{' following function declarations go on the next line > > > perf.c:73: ERROR: "foo*** bar" should be "foo ***bar" > > > perf.c:112: ERROR: space prohibited before that close parenthesis ')' > > > perf.c:127: ERROR: space prohibited before that close parenthesis ')' > > > perf.c:171: ERROR: "foo** bar" should be "foo **bar" > > > perf.c:213: ERROR: "(foo*)" should be "(foo *)" > > > perf.c:216: ERROR: "(foo*)" should be "(foo *)" > > > perf.c:217: ERROR: space required before that '*' (ctx:OxV) > > > perf.c:452: ERROR: do not initialise statics to 0 or NULL > > > perf.c:453: ERROR: do not initialise statics to 0 or NULL > > > > I'm ok with this, all comes from git lack of checkpatchin', from where > > this code was stolen^Wlifted, I guess :-) > > > > Acked-by: Arnaldo Carvalho de Melo <acme@redhat.com> > > Mind picking it up into your tree and sending it to me with your next series > of patches?
Sure thing.
- Arnaldo
| |