Messages in this thread | | | Subject | Re: [PATCH 01/01] regulator: support max8649 | From | Liam Girdwood <> | Date | Tue, 26 Jan 2010 11:01:41 +0000 |
| |
On Tue, 2010-01-26 at 01:26 -0500, Haojian Zhuang wrote: > From 2b5a73c336d2b5dc48c8cf1f2a804b6968659f78 Mon Sep 17 00:00:00 2001 > From: Haojian Zhuang <haojian.zhuang@marvell.com> > Date: Mon, 25 Jan 2010 10:24:09 -0500 > Subject: [PATCH] regulator: enable max8649 regulator driver > > Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
Can you confirm all the changes compared to the last version.
> +static int max8649_get_voltage(struct regulator_dev *rdev) > +{ > + struct max8649_regulator_info *info = rdev_get_drvdata(rdev); > + unsigned char data; > + int ret; > + > + ret = max8649_reg_read(info->i2c, info->vol_reg); > + if (ret < 0) > + return ret; > + data = (unsigned char)ret & MAX8649_VOL_MASK; > + return (max8649_list_voltage(rdev, data));
Any reason why we have extra () here ?
Thanks
Liam
| |